test: Add basic test for cli module

[amcintosh]

PR Checklist

• Follows single-purpose principle
• Tests pass locally (if applicable)
• Documentation updated (if needed)

What does this PR do?

Add a test for the cli module. This does not provide much cli coverage yet, but given the recent breakage I figured it was worth getting a start of cli tests.

Coverage:

Name                       Stmts   Miss Branch BrPart  Cover
------------------------------------------------------------
alix/__init__.py               1      0      0      0   100%
alix/cli.py                  776    597    284      5    18%
alix/clipboard.py             66     66     16      0     0%
alix/config.py                31     14      2      1    55%
alix/history_manager.py      134    134     46      0     0%
alix/models.py                55      0     10      2    97%
alix/porter.py                96     36     42      5    59%
alix/render.py                66     54     40      1    12%
alix/scanner.py               45      0     16      0   100%
alix/shell_detector.py       111     79     68      3    22%
alix/shell_integrator.py     135    105     32      1    20%
alix/shell_wrapper.py         63     23     16      4    58%
alix/storage.py              114     23     34      1    74%
alix/tui.py                  412    412    112      0     0%
alix/usage_tracker.py         92     10     24      5    85%
------------------------------------------------------------
TOTAL                       2197   1553    742     28    26%

Related Issue

Fixes #29

Type of change

• Bug fix (non-breaking)
• New feature (non-breaking)
• Configuration change
• Documentation update
• Setup/Infrastructure

[skalwaghe-56]

I request you to add tests for logic! Not asserting messages. @Valentin-v-Todorov I think there is no need for tests which assert messages. We need tests which test actual logic!

[skalwaghe-56]

I suggest you to add logic checks too! I have no problem with your current checks but you should add logic checks too! They are very important, and they should be more focused on.

[skalwaghe-56]

@amcintosh I can still see none logic checks. You can keep these output statements assetion logic there, but add core application logic checks. To check the actual application and not only the outputs. The current changes lgtm but please make the requested changes too. Thanks!

[skalwaghe-56]

I see that you are still asserting the output messages only.

[amcintosh]

The assertions are on lines 38-41. These are unit tests so I'm confining the scope of the test to the code in the cli.py module. The logic underneath would be tested in test_storage.py and presumably a test_shell_integrator.py.

[skalwaghe-56]

Ah that explains it.

[skalwaghe-56]

LGTM

[Valentin-v-Todorov]

@amcintosh LGTM!

Nice job!

[skalwaghe-56]

@amcintosh Had you not run the tests locally? These are failing please fix them and open a new PR. Make sure they pass for now reverting these changes.

[amcintosh]

@skalwaghe-56 I have run them all locally. I suspect it is due to other changes merged in. Hard to get test coverage up on a moving target.

[amcintosh]

@skalwaghe-56, @Valentin-v-Todorov: PR to re-add here: #80