Skip to content

fix: correct test expectations for field parsing #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Valentin-v-Todorov merged 1 commit into from
Sep 21, 2025
Merged

fix: correct test expectations for field parsing #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ def test_day_field_range_parsing():
output = f.getvalue()
assert result == 0
assert "Day of month field: 10-20" in output
assert "Values: [10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]" in output
# For 11 values, it should show truncated format
assert "Total: 11 values" in output


def test_day_field_step_parsing():
Expand Down
5 changes: 3 additions & 2 deletions tests/test_field_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,8 +668,9 @@ def test_parse_day_of_week_weekend(self):
def test_parse_day_of_week_step(self):
"""Test parsing day of week with step."""
field = self.parser.parse_day_of_week("1/2")
# Should give 1, 3, 5 (Mon, Wed, Fri)
assert field.parsed_values == {1, 3, 5}
# Should give 1, 3, 5, 7 where 7 converts to 0
# So the result is {0, 1, 3, 5}
assert field.parsed_values == {0, 1, 3, 5}

def test_parse_day_of_week_out_of_range_high(self):
"""Test parsing day value too high."""
Expand Down
Loading