Skip to content

TASK: Add Measurement class (#18)#46

Open
P-r-e-m-i-u-m wants to merge 1 commit intoTheGittyPerson:mainfrom
P-r-e-m-i-u-m:feature/measurement-class
Open

TASK: Add Measurement class (#18)#46
P-r-e-m-i-u-m wants to merge 1 commit intoTheGittyPerson:mainfrom
P-r-e-m-i-u-m:feature/measurement-class

Conversation

@P-r-e-m-i-u-m
Copy link
Contributor

@P-r-e-m-i-u-m P-r-e-m-i-u-m commented Mar 15, 2026

Closes #18

Added a Measurement class to store a value with a unit, and integrated it into Person.

Changes:

  • Added src/measurement.py with Measurement class
  • Supports units: m, cm, mm, ft, in
  • Includes to_metres(), to_unit(), describe(), and __eq__() methods
  • Updated Person.height type from float to Measurement | None
  • Added set_height() method to Person
  • Updated introduce() to use Measurement.describe()

@P-r-e-m-i-u-m P-r-e-m-i-u-m force-pushed the feature/measurement-class branch from 63c9ac2 to 5d6034d Compare March 15, 2026 16:33
@TheGittyPerson TheGittyPerson added enhancement New feature or request task This is a task issue / PR completing a task labels Mar 16, 2026
@P-r-e-m-i-u-m P-r-e-m-i-u-m mentioned this pull request Mar 16, 2026
Open
@TheGittyPerson TheGittyPerson mentioned this pull request Mar 17, 2026
Open
@TheGittyPerson TheGittyPerson force-pushed the feature/measurement-class branch from 5d6034d to b046bdf Compare March 17, 2026 16:30
@TheGittyPerson
Copy link
Owner

TheGittyPerson commented Mar 17, 2026

I updated your branch with a rebase 👍

@P-r-e-m-i-u-m @TheGittyPerson
feat: add Measurement class and set_height() method to Person
f9e264b 
Signed-off-by: 🄂ʏᴇᴅ 🄰ʙᴅᴜʟ 🄰ᴍᴀ🄝 ✧ <amanbaba9404522@gmail.com>

# Conflicts:
#	src/person.py

# Conflicts (second rebase conflict res):
#	theperson/measurement.py
#	theperson/person.py
@TheGittyPerson TheGittyPerson force-pushed the feature/measurement-class branch from b046bdf to f9e264b Compare March 19, 2026 07:59
@P-r-e-m-i-u-m P-r-e-m-i-u-m mentioned this pull request Mar 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request task This is a task issue / PR completing a task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TASK: Add Measurement class

2 participants

@P-r-e-m-i-u-m @TheGittyPerson