Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TheGittyPerson
changed the title
smile method (#50)
TheGittyPerson
added
enhancement
Owner
|
Will be reviewing in an hour 👍 |
TheGittyPerson
requested changes
Mar 19, 2026
Owner
TheGittyPerson
left a comment
TheGittyPerson
left a comment
There was a problem hiding this comment.
Thanks for your PR! Just a few formatting fixes before we move on
| """ | ||
| print("\U0001f44b") # Unicode for waving hand emoji | ||
|
|
||
| def smile(self,smile_type:str = "😊") -> None: |
Owner
There was a problem hiding this comment.
Since this is a static method, add @staticmethod before this line (and remove the self argument)
| """ | ||
| print("\U0001f44b") # Unicode for waving hand emoji | ||
|
|
||
| def smile(self,smile_type:str = "😊") -> None: |
Owner
There was a problem hiding this comment.
Also add a space after the comma and colon.
Comment on lines
+66
to
+68
| """Prints a smile emoji. | ||
| Args: smile_type:The type of smile to display. | ||
| options: '🙂', '☺️', '😊', '😁', '😄' """ |
Owner
There was a problem hiding this comment.
This is a bit weirdly formatted. Consider:
"""Print a smile emoji.
Args:
smile_type: The type of smile to display.
Options: '🙂', '☺️', '😊', '😁', '😄'
"""Notice the docstring should also be in imperative mood instead of descriptive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes here.
Closes #50
Changes
Resolves #50