Skip to content

Locale support - create and add #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjoblomj wants to merge 10 commits into from
Closed

Locale support - create and add #119

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a7ce924
Allowing users to specify which file properties to list
sjoblomj Oct 22, 2025
4ef8dd8
Fixing test by not displaying platform specific properties and adjust…
sjoblomj Oct 22, 2025
8077cde
Adding scaffolding to support locales
sjoblomj Oct 26, 2025
2a4c1af
Fixing warnings and linting
sjoblomj Oct 26, 2025
be76fb9
Correcting conftest setup
sjoblomj Oct 26, 2025
6ccaf50
Adding support for locales when listing
sjoblomj Oct 26, 2025
f271bba
Adding locale support for the create and add subcommands
sjoblomj Oct 26, 2025
2c0c8bf
Merge branch 'main' into locale-support-for-create-and-add
thomaslaurenson Nov 23, 2025
e679f68
Merge branch 'main' into locale-support-for-create-and-add
thomaslaurenson Nov 23, 2025
f4e3c08
Remove un-needed, duplicate stdout line
thomaslaurenson Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/mpq.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ int AddFiles(HANDLE hArchive, const std::string& target, LCID locale) {
}

int AddFile(HANDLE hArchive, const fs::path& localFile, const std::string& archiveFilePath, LCID locale) {

// Return if file doesn't exist on disk
if (!fs::exists(localFile)) {
std::cerr << "[!] File doesn't exist on disk: " << localFile << std::endl;
Expand Down