Downloads handled by bridge instead of mod #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteHusky
force-pushed
the
download-rendezvous
branch
from
6499fb8 to
216a38e
Compare
WhiteHusky
force-pushed
the
download-rendezvous
branch
4 times, most recently
from
1c96e38 to
5ce5edc
Compare
Contributor
Author
|
@AsciiJakob aka Verb reports the following numbers for a 233MB download on a 1Gbps connection. Game has the default limit framerate option (30FPS) when unfocused
|
WhiteHusky
force-pushed
the
download-rendezvous
branch
from
5ce5edc to
4c4ab4d
Compare
Contributor
Author
|
Fixed build issue; I had some changes that I'll wait for another PR for and selectively staged but kept back too much. |
WhiteHusky
force-pushed
the
download-rendezvous
branch
3 times, most recently
from
4c7b87a to
cca0c0e
Compare
Contributor
Author
|
This will fix #102 as an aside. |
Contributor
Author
|
May have forgotten to account for mods that updated. Additionally might need to change how mods are saved to avoid two mods of the same name from two servers clashing together (sha256 sum?) |
The bridge will be what handles downloading the mods instead of relying on the mod-side to write the files itself. The bridge communicates the progress of the file, however. Also introduces a basic state sharing framework but at the moment is used to share where mods should be downloaded to and a to-be-implemented switch to enable unix compatibility should the bridge not need to fix the given path download path. State is initially given by the mod on connect. Additionally a couple of miscellaneous things were changed that didn't age too well or were changed to be reused.
Felt like we should not delete files until we decide how much the bridge should do to manage mods and how it should be done.
WhiteHusky
force-pushed
the
download-rendezvous
branch
from
1cc8741 to
a4b4c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the mod receive the bytes directly, have the bridge place the files itself for the mod to find and move around into place as needed.
Also miscellaneous refactors.
Security considerations: The mod can tell the bridge to place the files anywhere, but the bridge will not overwrite files nor try to delete file paths it didn't create.