forked from HarbourMasters/Shipwright
-
Notifications
You must be signed in to change notification settings - Fork 0
Randomizer - Shuffle Roll #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TheLynk
wants to merge
54
commits into
develop
Choose a base branch
from
Shuffle-Roll
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arbourMasters#5936) * Autosave disabled when Ocarina of Time obtained but not Song of Time * Add explanation comment Added a condition to prevent autosaving between obtaining the Ocarina of Time and the Song of Time.
…aks to disable 2d backgrounds impl (HarbourMasters#5925)
…ourMasters#5943) * Fix bombchus being consistently added to excluded locations * change to be a random junk item
* Bump LUS, call `InitLogging` with both values at `trace`. Set up proper conditional default log level in Dev Tools. * Update LUS ref.
…feed into InitLogging. (HarbourMasters#5952)
* Update well logic for doorsanity Co-authored-by: Demur Rumed <junkmute@hotmail.com> * clang * Apply suggestions from code review Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> * Add adult + irons + hook to getting to west ledge * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> * post merge fixes * post merge fixes * renames and ground jumps * MQ updates * address reviews * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/dungeons/bottom_of_the_well.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> --------- Co-authored-by: Demur Rumed <junkmute@hotmail.com> Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com>
* refactor shadow logic * ground jump / hookshot extension * with groundjump invisible spikes room can be cleared, collecting silver rupees with backwalked backflips with hover boots * nb
TODO New model for items
…aBehavior.h Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
PABessero
requested changes
Nov 12, 2025
Collaborator
PABessero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for orthographic typos
soh/soh/Enhancements/randomizer/3drando/hint_list/hint_list_item.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
* refactor zoras river * Update soh/soh/Enhancements/randomizer/location_access/overworld/zoras_river.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/overworld/zoras_river.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/overworld/zoras_river.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/overworld/zoras_river.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/overworld/zoras_river.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/overworld/zoras_river.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/overworld/zoras_river.cpp Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> --------- Co-authored-by: Pepe20129 <72659707+Pepe20129@users.noreply.github.com>
* Load metadata without `LoadFile` on startup. Implement file type entry. * Fix non-Windows? * clang
* Fix: ground jump for haunted wasteland GS is hard, & can't be done with hammer Pulled this logic from zootr where sword is assumed, was not able to execute myself * Pepper0ni took a stab at this, wasn't able to do it, but didn't feel it wasn't doable * AGreenSpoon figured it out with BGS/hammer
* Modularize permanent loss mod hooks * Make RegisterBonkDamage static * Remove a couple of errant includes * Fix more errant includes
This is far and away the proudest thing I have been apart of in the Zelda community. Thank you to everyone who either directly or indirectly contributed to this effort. If I forgot to co-author you and you were involved, know that I simply forgot but still appreciated your help! Also thank you to the literal tens of thousands of people who have played Anchor, providing feedback and bug reports. Super thrilled to finally have this merged into the main Ship of Harkinian experience. Co-authored-by: mattman107 <65982675+mattman107@users.noreply.github.com> Co-authored-by: David Chavez <david@dcvz.io> Co-authored-by: MelonSpeedruns <melonspeedruns@outlook.com> Co-authored-by: aMannus <mannusmenting@gmail.com> Co-authored-by: Malkierian <malkierian@gmail.com> Co-authored-by: Caladius <Caladius@users.noreply.github.com> Co-authored-by: Patrick12115 <115201185+Patrick12115@users.noreply.github.com> Co-authored-by: PurpleHato <47987542+PurpleHato@users.noreply.github.com> Co-authored-by: balloondude2 <55861555+balloondude2@users.noreply.github.com> Co-authored-by: lilacLunatic <8488221+lilacLunatic@users.noreply.github.com> Co-authored-by: Felix Lee <flee135@users.noreply.github.com> Co-authored-by: Sirius902 <10891979+Sirius902@users.noreply.github.com>
Copper -> Develop 11/14
…pper Copper -> Dev fix (HarbourMasters#5962)
… in network thread (HarbourMasters#5969)
* Added new trick Skip Dodongo Cavern by using Bombchus to light the eyes * Update soh/soh/Enhancements/randomizer/location_access/dungeons/dodongos_cavern.cpp Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/location_access/dungeons/dodongos_cavern.cpp Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> --------- Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
* Modularize Hurt Container mode hook * Hook condition was wrong - fixed it * Change type of hurtEnabled for clarity * Change type back to bool * Add VB hook * Don't duplicate health capacity modifier calculation * Add constants, replace magic numbers * Clang format * Publicize more health unit macros * Make mod file self-contained
* Modularize equipment hand hooks * Remove unnecessary include * More efficient hammer hand hook * More efficient equipment visible hook * Add declarations of patching/resetting functions up front * Remove forward declarations * Make mod file self-contained
* A bit of cleanup on BGS hook * Cleanup on a few more hooks, fix itemId ref * Use direct pointer to params * Revert item receive ID hook setup * Remove callbacks from menu GUI * Add comments explaining conditions of permanent loss methods * Move custom skeletons hook to subfolder * Clang format * Shorten comment * Remove unnecessary re-register function call
- Returned support for custom tunic colors - Ocarina playback now audible - Fixed movement translation issue when climbing or going through crawlspaces - Fixed issue preventing some items from being visible in Dummy hands (namely ocarina) - Fixed stick length not correctly syncing
* Create AutoSyncFork.yml * Off * Delete .github/workflows/AutoSyncFork.yml * Fix Logic In GF
* Modularize Hyper Enemies hook * Use extern "C" * Make mod file self-contained
also make goron neck searchable
* Apply ImGui scaling when using presets * Make ImGuiScale function do nothing if scale setting is unchanged
* Use game over textures instead of save textures * Improves custom kaleido menu. Specifically: 1. Changes textures to the Game Over screen textures, which look the same but doesn't have "SAVE" at the top. 2. Adds a cursor on the left, doesn't currently do anything other than make it slightly clearer that you can move up and down and scroll, but opens the door for more menu-ing/toggling capabilities later. * Add fishing rod to kaleido menu * Adds skeleton key to kaleido menu with placeholder icon * More condensing of kaleido menu + add overworld keys * clang-format
* Adds new Progressive Bombchu Bags option Also changes existing code to account for Bombchu Bags becoming a drop down with 3 values instead of a checkbox * Handle the new lower capacities for ammo refills * Handle what happens when receiving a bombchu bag * Remove the trick name of Progressive Bombchu Bag Since, you know, that's an actual thing now. * Implements Bombchu Bag handling next to Progressive Bombchu Handling * clang-formatting * Add extra bag for plentiful items * Address review comment * Move bombchu upgrade level to gSaveContext and add save/load * Use logic's saveContext for correct logic calculations * Remove RG_PROGRESSIVE_BOMBCHU * Fix Bombchu Refill obtainability * Don't add normal chus to the pool if chu bags are on. * cmake-format * Properly reset bombchuUpgradeLevel on savefile init * Fix error with va_arg on linux * Fixes small error in the Bombchu Bag description * Fix bug with bombchu obtainability * clang-format * Fix infinite bombchu text * fix clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new setting randomizer "Shuffle Roll", shuffle ability do a roll for Link
Logic update for Tree and Break Crates
I am not against feedback or ideas for the custom model
And for All language Translation
And for logic
Thanks @PABessero for French Translation
Build Artifacts