Skip to content

Add /home landing page and /privacy policy page for Google OAuth compliance#43

Merged
TheOneWhoBurns merged 2 commits intorental-systemfrom
claude/fix-login-session-issue-gs3nR
Feb 6, 2026
Merged

Add /home landing page and /privacy policy page for Google OAuth compliance#43
TheOneWhoBurns merged 2 commits intorental-systemfrom
claude/fix-login-session-issue-gs3nR

Conversation

@TheOneWhoBurns
Copy link
Owner

@TheOneWhoBurns TheOneWhoBurns commented Feb 6, 2026

Summary by CodeRabbit

  • New Features
    • Added a home/landing page introducing the Rental Manager with login navigation
    • Added a comprehensive Privacy Policy page detailing data collection and usage practices

…liance

Google requires a homepage URL (different from the app root) that shows the
app name, and a separate privacy policy URL. These pages satisfy the OAuth
consent screen branding requirements.

https://claude.ai/code/session_01Rf47gNAgM7jDstC4bvffzw
@TheOneWhoBurns TheOneWhoBurns merged commit 270e791 into rental-system Feb 6, 2026
1 check failed
@TheOneWhoBurns TheOneWhoBurns deleted the claude/fix-login-session-issue-gs3nR branch February 6, 2026 22:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removes error handling from the shifts API endpoint, eliminating the try/catch wrapper and logging. Introduces two new static pages: a home landing page with a login link and a privacy policy page. Maintains existing API logic without centralized error handling.

Changes

Cohort / File(s) Summary
API Error Handling
src/routes/api/shifts/start/+server.ts
Removes try/catch block and all logger.error calls from endpoint handler; errors will now propagate uncaught. Functional logic preserved with minor formatting adjustments.
Static Pages
src/routes/home/+page.svelte, src/routes/privacy/+page.svelte
Two new static SvelteKit pages: home landing page with hero section and login link; privacy policy page with compliance sections, navigation, and embedded styling.

Possibly Related PRs

Poem

🐰 We've shed the error net with care,
Now errors float through silent air,
Two pages bloom—a home, a shield,
Privacy rights at last revealed! 🏠📋

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-login-session-issue-gs3nR

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants