Skip to content

Fix personal nodriver evaluate normalization #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genz27 merged 3 commits into from
Apr 17, 2026
Merged

Fix personal nodriver evaluate normalization #120

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9150642
Fix personal nodriver evaluate normalization
zy6p Apr 14, 2026
8a8f5c4
Address review on nodriver return_by_value handling
zy6p Apr 14, 2026
6b5e6c1
Merge remote-tracking branch 'origin/main' into pr-120-sync
genz27 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/services/browser_captcha_personal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ async def _tab_evaluate(
timeout_seconds: Optional[float] = None,
*,
await_promise: bool = False,
return_by_value: bool = False,
return_by_value: bool = True,
):
result = await self._run_with_timeout(
tab.evaluate(
Expand Down Expand Up @@ -2344,7 +2344,7 @@ async def _extract_tab_fingerprint(self, tab) -> Optional[Dict[str, Any]]:
"""从 nodriver 标签页提取浏览器指纹信息。"""
try:
fingerprint = await self._tab_evaluate(tab, """
() => {
(() => {
const ua = navigator.userAgent || "";
const lang = navigator.language || "";
const uaData = navigator.userAgentData || null;
Expand All @@ -2371,7 +2371,7 @@ async def _extract_tab_fingerprint(self, tab) -> Optional[Dict[str, Any]]:
sec_ch_ua_mobile: secChUaMobile,
sec_ch_ua_platform: secChUaPlatform,
};
}
})()
""", label="extract_tab_fingerprint", timeout_seconds=8.0)
if not isinstance(fingerprint, dict):
return None
Expand Down
Loading