feature/guild-skill-badge-v2-solidity#186
Merged
joelamouche merged 4 commits intoTheSoftwareDevGuild:mainfrom Apr 15, 2026
Merged
feature/guild-skill-badge-v2-solidity#186joelamouche merged 4 commits intoTheSoftwareDevGuild:mainfrom
joelamouche merged 4 commits intoTheSoftwareDevGuild:mainfrom
Conversation
adityagupta0251
requested review from
Teddy1792,
joelamouche and
oscarwroche
as code owners
Contributor
Author
|
@joelamouche you can check it out! |
joelamouche
reviewed
Apr 15, 2026
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
Looks pretty good overall! Just one fix needed
| @@ -0,0 +1,46 @@ | |||
| // SPDX-License-Identifier: MIT | |||
Contributor
There was a problem hiding this comment.
for some reason this is a duplicate of the src contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Guild Skill Badge (V2) as specified in issue #180.
Key changes:
string skillDescriptionandbytes32[] linkedBadges.