Found typos and bugs in allegro.js source#31
Open
alegemaate wants to merge 2 commits intoTheSos:masterfrom
Open
Found typos and bugs in allegro.js source#31alegemaate wants to merge 2 commits intoTheSos:masterfrom
alegemaate wants to merge 2 commits intoTheSos:masterfrom
Conversation
alegemaate
commented
Feb 12, 2021
alegemaate
commented
- Line 303: sx seems to have been copied and pasted leaving no sy
- Line 460: Mouse is misspelled which can cause issues with mouse y
- Line 558: installed timers is searching an element compared to an array (never true) instead of using passed argument
- Line 783: Log is attempting to print length of individual frame instead of sheet
Author
|
Oops forgot to run doxygen and crunch it, I will update this pr |
alegemaate
force-pushed
the
fix/typos-bugs
branch
from
1b1293e to
d7bc24e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.