fix: correct KV cache memory stats for K/V metadata and fp16 baseline #53
Open
dipeshbabu wants to merge 1 commit intoTheTom:mainfrom
Open
fix: correct KV cache memory stats for K/V metadata and fp16 baseline #53dipeshbabu wants to merge 1 commit intoTheTom:mainfrom
dipeshbabu wants to merge 1 commit intoTheTom:mainfrom
Conversation
Owner
|
hey there. thank you for the contribution. i'll be getting to them. I apologize for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
KVCacheCompressor.memory_stats()so it matches the actual storage layout used bycompress().The previous implementation undercounted memory in two ways:
What changed
d * k_bitsvector_normresidual_normd * v_bitsvector_normTests
Added an exact regression test in
tests/test_kv_cache.pythat checks the byte math for:head_dim=128k_bits=3v_bits=3seq_len=1num_layers=1num_heads=1Also verified the full KV cache test file passes.