test: document QJL regression in test_turboquant_improves_over_polarquant#62
Open
brosequist wants to merge 1 commit intoTheTom:mainfrom
Open
test: document QJL regression in test_turboquant_improves_over_polarquant#62brosequist wants to merge 1 commit intoTheTom:mainfrom
brosequist wants to merge 1 commit intoTheTom:mainfrom
Conversation
…uant The existing test ended with a print() and no assertion, silently allowing QJL to be worse than PolarQuant. This updates the test to assert the known finding: QJL (TurboQuant 2-bit) is actively worse than MSE-only PolarQuant at the same bit budget. The assertion will alert if QJL is ever fixed and starts winning, prompting re-evaluation of the production path. See turbo4-resurrection.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_turboquant_improves_over_polarquanthad no assertion — it only printed values. This adds a regression assertion documenting the empirical finding that QJL increases inner-product distortion (TQ 2-bit avg ≈ 0.091 vs PQ 2-bit avg ≈ 0.041).Test plan
pytest tests/test_distortion.py::TestDistortionScaling::test_turboquant_improves_over_polarquant🤖 Generated with Claude Code