Skip to content

fix: updated dependencies in setup.py and docker_test_requirements.txt #26#27

Open
zhouxiaochi wants to merge 1 commit intomainfrom
26-fix-python-derivation-agent-test-dependency-conflicts
Open

fix: updated dependencies in setup.py and docker_test_requirements.txt #26#27
zhouxiaochi wants to merge 1 commit intomainfrom
26-fix-python-derivation-agent-test-dependency-conflicts

Conversation

@zhouxiaochi
Copy link
Member

  • moved extras_require dependencies from setup to docker_test_requirements.txt for clarity as the dev options are all for running the tests

  • hard specified dependency versions in docjker_test_requirements.txt, as the latest versions will not work

Details regarding to the dependency conflicts can be found in issue #26

- moved extras_require dependencies from setup to docker_test_requirements.txt for clarity as the dev options are all for running the tests

- hard specified dependency versions in docjker_test_requirements.txt, as the latest versions will not work
@zhouxiaochi zhouxiaochi requested a review from gpeb2 May 7, 2025 14:45
@zhouxiaochi zhouxiaochi marked this pull request as ready for review May 7, 2025 16:05
@kok-foong
Copy link
Contributor

Is there any plan to look into python_wrapper? There are also some similar issues, probably related to pytest-docker-compose and pyyaml, applying similar changes do not seem to fix it there. Fixing the python_wrapper is probably a higher priority than the derivation agent in my opinion

@sm453
Copy link
Member

sm453 commented May 19, 2025

Is there any plan to look into python_wrapper?

Not at the moment. Perhaps @jb2197 would like to comment.

Fixing the python_wrapper is probably a higher priority than the derivation agent in my opinion

I certainly agree with that.

@jb2197
Copy link
Collaborator

jb2197 commented May 19, 2025

Is there any plan to look into python_wrapper? There are also some similar issues, probably related to pytest-docker-compose and pyyaml, applying similar changes do not seem to fix it there.

If the issue is related to the error from installing pyyaml, one workaround is to fix pyyaml==5.3, see yaml/pyyaml#724 (comment)

Not at the moment. Perhaps @jb2197 would like to comment.

I would recommend implementing the CI/CD for python_wrapper as the priority. Perhaps this is already the intention of #28? It might be better to wait the improvements for paper revision is merged first #31. As part of your CI/CD, you might want to consider including docs deployment as well, see #29 and #30.

Fixing the python_wrapper is probably a higher priority than the derivation agent in my opinion

I certainly agree with that.

In my view the python_derivation_agent folder can be scrapped as all of its functionalities and tests are already integrated into python_wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants