Conversation
…, and create different fields variables for non serial columns
…ava version to 11
…initialised properly and fixed prepareMapping
Closed
…ue when class is a Point and SRID is null during initialisation, as well as updated stack-clients version
…eSeriesRDBClientOntop` class to the stack-client library to remove the circular dependency between the two projects.
…east one dependncy requires it.
…-clients project.
…dAvatar/BaseLib into 54-time-series-for-ontop
…tDataTypeTableIfNotExists` methods to remove JOOQ `..Step` class instances.
…xists, replaced List.of, and fixed equality for PRECONFIGURED_SRID
…at does not exist
… match existing behaviour
…BClientIntegrationTest for TimeSeriesRDBClientOntop but modified for some different behaviours
sm453
approved these changes
Nov 10, 2025
Member
sm453
left a comment
sm453
left a comment
There was a problem hiding this comment.
Looks ok to me, though have not tested.
…lientFactory to work when it is created via a federated endpoint
…n/main' into 54-time-series-for-ontop
…n/main' into 54-time-series-for-ontop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main addition is the TimeSeriesRDBClientOntop class.
Please refer to the README.md for an overview of this class (link to Ontop mapping will resolve after the corresponding stack-clients is merged)