Remove Tabindex Attribute #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tabindex attribute on the search widget and comment section shouldn't be added by the parent theme, there are a lot of arguments not to use it at all since the browser will naturally tab through the document structure. On top of that, the parent theme doesn't know how the child theme will handle the layout and shouldn't be handling it for that reason also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabindex attribute on the search widget and comment section shouldn't be added by the parent theme, there are a lot of arguments not to use it at all since the browser will naturally tab through the
document structure.
On top of that, the parent theme doesn't know how the child theme will handle the layout and shouldn't be handling it for that reason also.
There are a bunch of edits because SublimeText is setup to remove trailing whitespace, which also includes empty tabs. Most style guides for projects recommend to remove these anyway.
I heard shoptalk show mention tabindex and remembered the search form having tabindex use to drive me crazy, just forgot about it. Also as a reference http://webaim.org/techniques/keyboard/tabindex