Skip to content

fix: Asymmetric Payout Arithmetic and Consistency Refactor #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gboigwe merged 1 commit into from
Mar 28, 2026
Merged

fix: Asymmetric Payout Arithmetic and Consistency Refactor #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions contracts/payout-automation/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,21 @@ impl PayoutAutomationContract {
panic!("unauthorized");
}

if amount <= 0 {
panic!("amount must be positive");
}

let min_payout: i128 = env.storage().instance().get(&DataKey::MinPayoutAmount).unwrap_or(1_000_000);
if amount < min_payout {
panic!("amount below minimum payout");
}

let counter: u64 = env
.storage()
.instance()
.get(&DataKey::PayoutCounter)
.unwrap_or(0);
let payout_id = counter + 1;
let payout_id = counter.checked_add(1).expect("counter overflow");

let token_addr: Address = env
.storage()
Expand Down Expand Up @@ -193,8 +202,14 @@ impl PayoutAutomationContract {
last_payout: 0,
});

earnings.total_paid += payout.amount;
earnings.pending_amount = earnings.pending_amount.saturating_sub(payout.amount);
earnings.total_paid = earnings
.total_paid
.checked_add(payout.amount)
.expect("total_paid overflow");
earnings.pending_amount = earnings
.pending_amount
.checked_sub(payout.amount)
.expect("insufficient pending earnings");
earnings.last_payout = env.ledger().timestamp();
env.storage().persistent().set(&key, &earnings);
env.storage().persistent().extend_ttl(
Expand Down Expand Up @@ -231,7 +246,14 @@ impl PayoutAutomationContract {
last_payout: 0,
});

earnings.pending_amount += amount;
if amount <= 0 {
panic!("amount must be positive");
}

earnings.pending_amount = earnings
.pending_amount
.checked_add(amount)
.expect("pending_amount overflow");
env.storage().persistent().set(&key, &earnings);
env.storage().persistent().extend_ttl(
&key,
Expand Down
Loading