fix: bridge-fee arithmetic overflow remediation#347
Merged
gboigwe merged 1 commit intoThinkLikeAFounder:mainfrom Mar 28, 2026
Merged
Conversation
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #306
Description:
This PR addresses a critical arithmetic safety issue in the cross-chain token bridge (
token-bridgecontract) where bridge fee calculations used unchecked multiplication.Key Changes:
deposit_for_bridgenow useschecked_mul. This prevents potential intermediate result overflows when handling extremely large transfer amounts.expect()to ensure the contract halts safely with a descriptive error message if an overflow is reached, rather than silently wrapping to an incorrect value.