[Experimental] Improved integrated tests with nRF52840-Dongles#172
Open
mdxs wants to merge 1 commit intoThomasGerstenberg:masterfrom
Open
[Experimental] Improved integrated tests with nRF52840-Dongles#172mdxs wants to merge 1 commit intoThomasGerstenberg:masterfrom
mdxs wants to merge 1 commit intoThomasGerstenberg:masterfrom
Conversation
mdxs
changed the title
Contributor
Author
|
When testing with just two nRF52840-Dongle (PCA10056) devices, it appears that I get all tests completed (with the PR applied): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run the
make run-testswith 2x nRF52840-Dongle (PCA10056) and 1x the nRF52-DK (PCA10040; a Dev Kit for the nRF52832), the nature of the nRF52840-Dongle to reset with breaking the USB device connection causes the tests to fail in the current code base after some tests:One of the errors seen is the
NrfError.rpc_h5_transport_state, which was also reported in #75 and #103 - in which I wrote about a workaround that worked for me on Linux (I've not yet tested it on Windows).Using that approach in this PR improved the number of tests performed with
make run-testson Linux, though it doesn't seem to complete all the tests either:Right now, I don't know what caused this particular error. Perhaps it is a callback with something after the devices have been closed. But I honestly didn't look into this too much at this point...
So this PR is improving the ability to test Blatann when using the nRF52840-Dongle (one or more), but it is clearly incomplete and thus I marked it [Experimental]. I've also added PySerial to the requirements and updated the
pc-ble-driver-pyrequirement to use the latest v0.17 to make it explicit under which conditions I've started the tests.