Skip to content

Add clear all filters button#261

Merged
BibianaC merged 3 commits intolivefrom
bc/add-clear-all-filters-button
Mar 3, 2026
Merged

Add clear all filters button#261
BibianaC merged 3 commits intolivefrom
bc/add-clear-all-filters-button

Conversation

@BibianaC
Copy link
Member

Related to #251

Screenshot 2026-02-26 at 12 17 28

@BibianaC
Copy link
Member Author

The tests are failing because coveralls is experiencing a service outage. While they fix the issue, the PR can be reviewed.

mrshll1001
mrshll1001 previously approved these changes Feb 27, 2026
Copy link

@mrshll1001 mrshll1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy that these changes work and are inkeeping with the style and structure of the codebase. :-)

R2ZER0
R2ZER0 previously approved these changes Feb 27, 2026
Copy link
Contributor

@R2ZER0 R2ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks! I'll leave it to @mariongalley re. UI style

@mariongalley
Copy link

@BibianaC UI looks good to me. Please can the hyperlink text be "Clear all" instead of just "clear"

@BibianaC BibianaC dismissed stale reviews from R2ZER0 and mrshll1001 via 24ba0f5 March 3, 2026 09:29
@coveralls
Copy link

coveralls commented Mar 3, 2026

Pull Request Test Coverage Report for Build 22616732180

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.957%

Totals Coverage Status
Change from base Build 21749553530: 0.0%
Covered Lines: 31
Relevant Lines: 47

💛 - Coveralls

@BibianaC BibianaC requested review from R2ZER0 and mrshll1001 March 3, 2026 09:43
@BibianaC
Copy link
Member Author

BibianaC commented Mar 3, 2026

@mariongalley I have done the change.

@BibianaC BibianaC merged commit d07b548 into live Mar 3, 2026
4 checks passed
@BibianaC BibianaC deleted the bc/add-clear-all-filters-button branch March 3, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants