Skip to content

Conversation

@aisk
Copy link
Member

@aisk aisk commented Jan 28, 2021

So we can get better error message for which ip / port is called.

@aisk
Copy link
Member Author

aisk commented Jan 28, 2021

Seems the test cases are excepecting error socket.timeout, so this will be a breaking change?

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #160 (efede5f) into master (108cca5) will decrease coverage by 0.28%.
The diff coverage is 42.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   83.35%   83.06%   -0.29%     
==========================================
  Files          43       43              
  Lines        3935     3951      +16     
==========================================
+ Hits         3280     3282       +2     
- Misses        655      669      +14     
Impacted Files Coverage Δ
thriftpy2/transport/sslsocket.py 89.58% <ø> (ø)
thriftpy2/transport/socket.py 84.35% <41.17%> (-8.78%) ⬇️
thriftpy2/rpc.py 81.94% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108cca5...efede5f. Read the comment docs.

@aisk aisk changed the title translate socket.timeout to TTransportException WIP: translate socket.timeout to TTransportException Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants