Skip to content

Conversation

@pail23
Copy link

@pail23 pail23 commented Apr 28, 2025

This PR includes the enhanced api. The old api stays in place for backward compatibility (for now?).

The api folder contains the csv file describing the registers. The script folder contains the scripts to generate the python files (lwz.py and wpm.py). The__init__.pyfile is enhanced with based classes.

@pail23
Copy link
Author

pail23 commented May 8, 2025

@ThyMYthOS Is there anything I can do to support the review and merge of this PR?

@ThyMYthOS
Copy link
Owner

@ThyMYthOS Is there anything I can do to support the review and merge of this PR?

Is this new API taken from https://github.com/pail23/stiebel_eltron_isg_component? Or do you plan to use this library there as well?

Copy link
Owner

@ThyMYthOS ThyMYthOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a README.md to the api folder with some information from where you have taken the *.csv files and how to update them if required?

@pail23
Copy link
Author

pail23 commented May 10, 2025

Currently the Stiebel Eltron ISG Home Assistant Component contains a copy of the generated files, identical to the ones in this PR. After the merge of the PR and the next release of this python package, I intend to replace the copy in the Home Assistant component by a reference to this python package.

I have added a README.md file to the api folder.

@ThyMYthOS ThyMYthOS merged commit f548808 into ThyMYthOS:master May 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants