VCF-42: Reduce memory consumption when a single position returns many samples #867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the header for every sample returned for a single position was being loaded into memory. However, many headers are identical except for their sample line, meaning basically the same headers were being loaded multiple times per position.
To alleviate the issue, this PR computes the MD5 checksum for each header (minus the sample line) and only stores the unique ones. Samples are then associated with the correct header using an associative array.
Notes about the implementation: