Skip to content

Enable CI for pull requests #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimNN merged 4 commits into from
Feb 8, 2021
Merged

Enable CI for pull requests #48

TimNN merged 4 commits into from
Feb 8, 2021

Conversation

@TimNN
Copy link
Owner

@TimNN TimNN commented Feb 8, 2021 •
edited
Loading

cc @messense: I've cherry-picked this from your #47, thanks!

Additional changes:

  • Only run for pushes to master.
  • Fix the toolchain version selection (it was hardcoded to stable instead of referring to the matrix variable).
  • Don't run cargo check on stable, because it breaks cargo clippy running afterwards.

@TimNN TimNN enabled auto-merge February 8, 2021 15:20
@TimNN TimNN disabled auto-merge February 8, 2021 15:24
@TimNN TimNN mentioned this pull request Feb 8, 2021
Open
@TimNN TimNN merged commit 7aff975 into master Feb 8, 2021
@TimNN TimNN deleted the ci-pull branch February 8, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimNN @messense