Refactor v46 datatable introduction #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse - Add from_query_response() method to convert JSON data to DataTable - Implement proper type inference for columns - Add F6 demo to show DataTable conversion with memory comparison - DataTable uses typed DataValue enum instead of JSON - Shows significant memory reduction potential This is the foundation for migrating away from JSON-based storage to a more efficient columnar DataTable architecture.
- Move 20 shell scripts to integration_tests/test_scripts/ - Move 14 CSV test files to integration_tests/test_data/ - Move 34 Rust test files to integration_tests/ - Update README with new directory structure - Clean up main directory from test clutter This keeps the project root clean and organizes tests logically.
- F6 now only shows DataTable conversion, doesn't switch to PrettyQuery - F7 now shows Pretty Query view (moved from F6) - Status message shows memory comparison: 'JSON ~XKB vs DataTable ~YKB' - Debug logs show column type details when RUST_LOG=debug The status message was being immediately overwritten by PrettyQuery mode.
- F6 was only handled in Command mode, not Results mode - Added F6 handler to handle_results_input() function - Now pressing F6 in Results mode will show DataTable conversion - Status message displays memory comparison in status bar The demo now works correctly from Results view where users spend most time.
- DataTable now counts actual string content, not just enum size - JSON size calculation includes field name duplication overhead - More accurate memory comparison for real-world data For 10k rows with 53 columns, the estimates should now be more realistic, showing actual memory usage including string content and overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.