Tui module vim search #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 29 section markers to group related functionality - No code changes, only organizational comments - Preparation for future refactoring to break down the 9800+ line file - Sections include: Navigation, Column Operations, Yank, Rendering, etc.
- Created enhanced_tui_helpers.rs for pure functions - Moved sanitize_table_name (1 of 7 pure functions) - Reduced enhanced_tui.rs by 33 lines - This is the first step in reducing coupling in the TUI
- Added apply_row_navigation_result() helper to consolidate state updates - Simplified next_row() from 29 lines to 11 lines - This removes the duplicated state updates that were in every navigation method - Navigation now has a single place where state is synchronized This is the first step in reducing coupling in navigation. The pattern: 1. Call ViewportManager to get navigation result 2. Apply result using helper method 3. No more updating 3-4 different places manually
- Applied same pattern as next_row - Reduced from 29 lines to 11 lines - Uses apply_row_navigation_result helper to consolidate state updates - Both up/down navigation now follow the same clean pattern Ready to apply this pattern to remaining 11 navigation methods
- Added apply_column_navigation_result() helper - Simplified move_column_left from 51 to 13 lines (74% reduction) - Simplified move_column_right from 62 to 13 lines (79% reduction) - Follows same pattern as row navigation helpers Column navigation now uses single helper for state updates instead of duplicating the same updates in every method. Ready for testing before applying to remaining navigation methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.