Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
55fe9d9
[base] Update exception handling for elementIndex
ischoegl Oct 13, 2025
4bdc6e7
[base] Make element index checking more consistent
ischoegl Oct 13, 2025
b2d6490
[base] Improve exception handling for speciesIndex
ischoegl Oct 13, 2025
d58a32d
[base] Make checkSpeciesIndex more useful
ischoegl Oct 13, 2025
b23315e
[base] Make phaseIndex more consistent
ischoegl Oct 13, 2025
acced3d
[base] Address additional indices/deprecations
ischoegl Oct 13, 2025
99140c6
[zeroD] Always raise exception for invalid entries
ischoegl Oct 13, 2025
1eb8e3c
[base] Make exception messages consistent
ischoegl Oct 13, 2025
131cf7b
[Python] Simplify Sim1D.domain_index
ischoegl Oct 17, 2025
2d205b9
[unittest] Fix legacy CLib unit tests
ischoegl Oct 13, 2025
024a3cf
[mix] Make return type consistent
ischoegl Oct 17, 2025
df45cd3
Address review comments
ischoegl Oct 19, 2025
786f6c2
[base] Only issue warnings if <abc>Index behavior changes
ischoegl Oct 19, 2025
80ed3db
[legacy CLib] Add pragma deprecation warnings
ischoegl Oct 19, 2025
61f25b7
[Kinetics] Implement raise option for kineticsSpeciesIndex
ischoegl Oct 20, 2025
5e351a1
[CLib] Implement temporary custom code
ischoegl Oct 20, 2025
2dc569e
Initial cut at Python type stubs.
TimothyEDawson Jul 11, 2025
9ee0d2f
Add myself to AUTHORS.md
TimothyEDawson Aug 1, 2025
c033407
Merge simple stubs into code.
TimothyEDawson Aug 16, 2025
56999f3
Add initial pyright and mypy settings to pyproject.toml.
TimothyEDawson Aug 20, 2025
0141249
Add typing utility functions and improve yaml2ck.py.
TimothyEDawson Oct 15, 2025
ae129a0
Remove unnecessary __all__ from _types.pyi.
TimothyEDawson Oct 15, 2025
ed4fa6d
Add type ignores until Mypy gets TypeForm support.
TimothyEDawson Oct 16, 2025
6c43516
Add Python API type checking to CI.
TimothyEDawson Oct 14, 2025
04a4779
Address several review comments.
TimothyEDawson Oct 20, 2025
1901684
Trim CI pipeline for testing.
TimothyEDawson Oct 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 12 additions & 21 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,25 +65,16 @@ jobs:
git config --global core.whitespace \
-cr-at-eol,tab-in-indent,blank-at-eol,blank-at-eof
git diff --check ${{ github.event.pull_request.base.sha }}
example-data:
name: Check for unmerged example-data pull request
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v5
name: Checkout the repository
with:
fetch-depth: 100
persist-credentials: true

- name: Find matching PR in example_data
env:
BASE_PR: ${{ github.event.number }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Static type checking for Python interface
- name: Install mypy, basedpyright, and dependencies
run: |
cd data/example_data
DATA_PR=$(gh pr list --repo Cantera/cantera-example-data --jq '.[] | select(.title | test("Cantera/cantera#'${BASE_PR}'")) | .number' --json title,number)
if [ -n "$DATA_PR" ]; then
echo ":exclamation: Merge https://github.com/Cantera/cantera-example-data/pull/${DATA_PR} and update the submodule commit before merging this PR" >> $GITHUB_STEP_SUMMARY
exit 1
fi
python -m pip install --upgrade pip
pip install mypy basedpyright numpy ruamel.yaml pandas pandas-stubs \
pint graphviz setuptools typing_extensions
- name: Run mypy
working-directory: interfaces/cython
run: mypy --config-file pyproject.toml --python-version 3.10
- name: Run basedpyright
if: failure() || success()
working-directory: interfaces/cython
run: basedpyright --pythonversion 3.10
Loading
Loading