feat: Add Docker containerization for D2WeaponReport#143
Open
feat: Add Docker containerization for D2WeaponReport#143
Conversation
Add multi-stage Dockerfile that builds the application, downloads the Bungie manifest via InitEnvironment, and creates a lightweight runtime image. Includes docker-compose for easy local development. - Add Dockerfile with 3-stage build (build, init, runtime) - Add .dockerignore to exclude build artifacts - Add docker-compose.yml mapping port 5050 - Add skipLibCheck to tsconfig.json for TypeScript compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
Review this and fully see what I am adding. port 5000 is already taken on the mac (learned this the hard way on the VRC project ) and i was having issues without turning it into a docker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipLibCheck: trueto tsconfig.json for TypeScript build compatibilityTest plan
docker build -t d2weaponreport .to build the imagedocker run -p 5050:80 d2weaponreportto start the containerdocker-compose upto build and run🤖 Generated with Claude Code