Fix thread safety in DelayedFuncTask class#5
Open
p0358 wants to merge 2 commits intoTitanfall-Mods:masterfrom
Open
Fix thread safety in DelayedFuncTask class#5p0358 wants to merge 2 commits intoTitanfall-Mods:masterfrom
p0358 wants to merge 2 commits intoTitanfall-Mods:masterfrom
Conversation
Author
|
Actually now that I think about it, TTF2SDK::AddFrameTask and then removal in main frame hook is also unsafe, idk if the codebase assumes a possibility someone might add frame task from another thread, I see so far the only AddFrameTask calls are done in main thread... Should I fix it too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunFrame()was accessingm_delayedFuncsinsecurely without holding a lock on mutex.I also changed std::mutex to std::recursive_mutex, because if a delayed func called from RunFrame() calls AddFunc() again itself, it would create a deadlock with normal mutex...