feat: Dynamisches Abrufen der aktuellen Megakino-Domain #3
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The domain for the megakino website has been updated from megakino.ms to megakino.lol. This change updates the application to use the new domain. The code has also been refactored to use a BASE_URL constant in `megakino/src/common.py` to improve maintainability and avoid hardcoded URLs in multiple files.
…128529902 feat: Update megakino domain to megakino.lol
Moved the import of `search_for_movie` inside the `get_html_from_search` function in `megakino/src/common.py`. This change breaks a circular dependency where `common.py` imported `search.py` at the module level, and `search.py` imported `common.py`. By deferring the import to when it is needed within the function, the modules can be initialized without error.
…128529902 fix: Resolve circular import between common and search
Die hartcodierte `BASE_URL` wurde durch eine Funktion ersetzt, die die aktuelle Domain dynamisch von einer externen URL abruft. - Eine neue Funktion, `get_latest_domain`, wurde in `megakino/src/common.py` hinzugefügt, um die neueste Domain von https://raw.githubusercontent.com/Yezun-hikari/new-domain-check/refs/heads/main/monitors/megakino/domain.txt abzurufen. - Bei einem Fehler beim Abrufen der URL wird auf eine hartcodierte Fallback-Domain (`https://megakino.lol`) zurückgegriffen, um die Funktionalität sicherzustellen. - Die `BASE_URL`-Konstante wird nun durch den Aufruf dieser Funktion initialisiert, wodurch die Anwendung immer die aktuellste Domain verwendet, ohne dass manuelle Updates erforderlich sind.
…ng-6346600661275439559 Dynamisches Abrufen der Domain
Author
English Translation of PR DescriptionSummaryThis Pull Request implements a dynamic system for retrieving the current Megakino domain to automatically handle domain changes. ChangesNew Functionality
Technical Details
Benefits
Changed Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zusammenfassung
Dieser Pull Request implementiert ein dynamisches System zum Abrufen der aktuellen Megakino-Domain, um automatisch mit Domain-Änderungen umzugehen.
Änderungen
Neue Funktionalität
BASE_URLwurde durch eine neue Funktionget_latest_domain()ersetzt, die automatisch die aktuelle Megakino-Domain von einem externen Service abruftTechnische Details
https://raw.githubusercontent.com/Yezun-hikari/new-domain-check/refs/heads/main/monitors/megakino/domain.txtabraise_for_status()für HTTP-FehlerbehandlungVorteile
Geänderte Dateien
megakino/src/common.py: Ersetzung der hartcodiertenBASE_URLdurch dynamisches Abrufen