Conversation
|
Hi @phacic, thanks for taking the time to do this and for submitting a pull request but as far as this package is concerned I'd like to not stray too far from the work of the official fastapi-users adapters. I think that the management of users personal info should be done on the application code side of things according to each one needs. I for example since I've watched this I avoid using the Fastapi-users allows the developer to manage the specific information of their users as they wish through customization. I think that these fields do not belong in the database adapter. |
|
hello, @Tobi-De I completely understand your point but I can see some people benefiting from these fields and since they are optional and overridable they won't have any adverse effect I can think of. Also, can we open a PR with Fastapi-users and add your work to the official repo |
The reason this repo was created was because The maintainer of the project made the hard decision to drop support because almost nobody used |
first_nameandlast_namefieldsusernamefield with validationdate_joined field