Merged
Conversation
added 7 commits
February 24, 2026 10:41
…luate_prepared_state methods
…and add unit tests
… in FastMultipoleMethod
- Updated max_leaf_size handling to use a correctness-preserving upper bound in JIT paths. - Refactored FMMPreparedState from NamedTuple to a frozen dataclass, enabling better integration with JAX's pytree utilities. - Implemented tree_flatten and tree_unflatten methods for FMMPreparedState to manage auxiliary data and ensure compatibility with JAX transformations. - Added utility function _contains_tracer to check for JAX tracer values in inputs. - Modified FastMultipoleMethod to support stateful caching, preventing tracer leakage into solver caches. - Introduced tests to validate JIT execution of prepared states and ensure no tracer leakage occurs during computations.
… configurations - Introduced `compare_yggdrax_jaccpot_prepare.py` to benchmark tree/traversal timings between yggdrax and jaccpot. - Added default traversal configuration for kdtree in jaccpot's FMM implementation. - Updated FMM to support adaptive tree build mode. - Changed fast preset to use lbvh tree build mode instead of fixed depth. - Modified integration test to reflect changes in fast preset defaults.
…support - Introduced local functions to encapsulate computation logic within the `_compute_leaf_p2p_impl` function, enhancing readability and maintainability. - Utilized `lax.cond` to conditionally execute computations based on the validity of edges, optimizing performance by avoiding unnecessary calculations. - Added new constants for tracing configurations in `_fmm_impl.py` to limit maximum neighbors and interactions per node during tracing, preventing overflow and improving efficiency. - Implemented a method to resolve tracing traversal configurations, ensuring that the system adapts to different operational contexts while maintaining performance. - Adjusted leaf capacity handling to ensure consistency between eager and traced modes, enhancing overall stability and performance of the Fast Multipole Method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some clean up of the API for better interfacing with ODISSEO