Skip to content

Conversation

@DanicaSTFC
Copy link
Contributor

@DanicaSTFC DanicaSTFC commented Apr 23, 2025

  • closes Add color bar to registration viewer #384
  • the visibility of the bar is in sync with the buttons
  • the rendering of the range is in sync with the translation values
  • the window level etc are not in sync. add observer

@DanicaSTFC DanicaSTFC added this to the Version 25.0.0 milestone Apr 23, 2025
@DanicaSTFC DanicaSTFC self-assigned this Apr 23, 2025
@DanicaSTFC DanicaSTFC moved this to ❓ Need help in iDVC Planning Apr 23, 2025
Comment on lines 3987 to 3995
data = self.subtract.GetOutput()

# Retrieve the scalar data from the output
scalars = data.GetPointData().GetScalars()

# Check if scalars exist in the data

# Get the min and max scalar values
cmin, cmax = scalars.GetRange()
Copy link
Contributor

@paskino paskino Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought that this would be sufficient.

Suggested change
data = self.subtract.GetOutput()
# Retrieve the scalar data from the output
scalars = data.GetPointData().GetScalars()
# Check if scalars exist in the data
# Get the min and max scalar values
cmin, cmax = scalars.GetRange()
v = self.vis_widget_reg.frame.viewer
# make sure the stats are updated
v.ia.Update()
cmin = v.ia.GetMinimum()
cmax = v.ia.GetMaximum()

I don't see you connected any observer?

@DanicaSTFC DanicaSTFC linked an issue Apr 29, 2025 that may be closed by this pull request
@DanicaSTFC
Copy link
Contributor Author

DanicaSTFC commented Jul 7, 2025

07/07/2025

We will not have time to finalise the observers. Danica is going on leave. Ideally, we would want to add this feature in the CILViewer. We are pausing this PR for the moment.

Edo is keener to have the #169 instead of simply this.

@DanicaSTFC DanicaSTFC moved this from ❓ Need help to ⌛ On hold in iDVC Planning Jul 7, 2025
@DanicaSTFC DanicaSTFC removed this from the Version 25.0.0 milestone Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ⌛ On hold

Development

Successfully merging this pull request may close these issues.

Add color bar to registration viewer

3 participants