Skip to content

1.12.23 + 1.12.24#183

Draft
shanperera wants to merge 32 commits intoTonic-Box:mainfrom
shanperera:rev-update-1.12.23
Draft

1.12.23 + 1.12.24#183
shanperera wants to merge 32 commits intoTonic-Box:mainfrom
shanperera:rev-update-1.12.23

Conversation

@shanperera
Copy link
Copy Markdown

@shanperera shanperera commented Apr 12, 2026

  • Updated mappings.json and packets.json for revision 1.12.23

  • Account type removal: Removed setAccountTypeLegacy/setAccountTypeJagex from TClient, TLoginMixin, LoginService and ProfilesSession, it seems like these mappings no longer exist in the current revision

  • Fix crash when JRE lookup returns 429 error

  • Update TLoginHashMixin for rev

  • Minimap walk packet uses multiplexed packet OP_RESUME_STRINGDIALOG, create PacketWriter func, Update PacketMapReader and packets to allow for multiplexer execution flow with subOpcode. Adds support for multiplexed packets that use the same ID in packets.json

  • GameObject, GroundItem, NPC now use subop packets like Runelite

  • Swap Add byte read and writes so packet fields send expected data contract to server instead of garbled data for packets that use those functions

Mappings and Packets should be fixed now, feel free to test it but do so at your own risk. A ban is always possible Still a WIP, use at your own risk

@shanperera shanperera marked this pull request as ready for review April 12, 2026 02:54
@Septharoth
Copy link
Copy Markdown
Contributor

this update is unsafe to use because it's missing a few things, be careful. packets are also not updated.

@shanperera
Copy link
Copy Markdown
Author

I thought I updated all the packets but I guess I missed some, apart from the packets: what else is missing?

@shanperera shanperera marked this pull request as draft April 12, 2026 05:11
@Septharoth
Copy link
Copy Markdown
Contributor

well youre missing the new packet definitions where some of them got a subop field (unused atm though)
TLoginHash needs updating as well.

@shanperera
Copy link
Copy Markdown
Author

I just realized I updated the packets.json on my end but not in the PR. I'll take another look into the new definitions in case I missed them. I'll look into TLoginHash as well. Appreciate the guidance, thanks!

@shanperera shanperera marked this pull request as ready for review April 13, 2026 14:08
@shanperera shanperera marked this pull request as draft April 14, 2026 12:20
@shanperera shanperera marked this pull request as ready for review April 14, 2026 14:05
@shanperera
Copy link
Copy Markdown
Author

Found an issue with GroundActions mapping to InventoryActions, fixed this mapping and tested mapping by calling NPCEx, TileItemEx, TileObjectEx, ItemContainerEx APIs and calling getMenuEntries() during runtime, everything seems in order.

@shanperera shanperera marked this pull request as draft April 15, 2026 08:33
@shanperera shanperera changed the title 1.12.23 1.12.23 + 1.12.24 Apr 17, 2026
@shanperera shanperera marked this pull request as ready for review April 18, 2026 03:02
@shanperera shanperera marked this pull request as draft April 18, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants