[WIP] new tower placement algorithm, fixes bugs and improves#451
Open
sparr wants to merge 1 commit intoTooAngel:masterfrom
Open
[WIP] new tower placement algorithm, fixes bugs and improves#451sparr wants to merge 1 commit intoTooAngel:masterfrom
sparr wants to merge 1 commit intoTooAngel:masterfrom
Conversation
samogot
reviewed
Sep 29, 2017
| return false; | ||
| }; | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
this function should be placed in _routing or somewhere else, but not in _memory file
Contributor
Author
There was a problem hiding this comment.
I'm conflicted. It's theoretically a routing function, but the only place it's currently called is in_memory. I decided to put it here until/unless it gets used somewhere else. I could easily be convinced otherwise.
sparr
changed the title
Contributor
Author
|
Marking this WIP. Will get combined into a single new-base-layout patch to avoid rebuilding existing bases. |
sparr
changed the title
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new helper function, Room.getMemoryPathSidewalk(). This produces a path-like list that contains every position on one side of a memorized path. This function is then used to fix the tower/filler/link placement code to avoid the previous problems where there would be gaps between those positions. I also included improvements like using both sides of the road and packing the positions closer together on diagonal roads.
Example of new layout:
Fixes #445