Need to close the handle when there is a cache hit#372
Merged
TooTallNate merged 3 commits intoTooTallNate:mainfrom Jul 7, 2025
Merged
Need to close the handle when there is a cache hit#372TooTallNate merged 3 commits intoTooTallNate:mainfrom
TooTallNate merged 3 commits intoTooTallNate:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 192bae1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brosell
changed the title
TooTallNate
approved these changes
May 9, 2025
Contributor
Author
|
@TooTallNate, when could this be merged and have a get-uri release? Just wondering if there is a release roadmap so I can plan when we can stop using our patched version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found that the
pac-proxy-agentwas leaking file descriptors viagetUrifor file basedpac.jswhenever there is a cache hit. This PR includes the fix we use to avoid the leak.#373