Skip to content

Backend improvements #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brichards64 merged 8 commits into from
Jul 30, 2025
Merged

Backend improvements #37

brichards64 merged 8 commits into from
Jul 30, 2025

Conversation

@marc1uk
Copy link
Contributor

@marc1uk marc1uk commented Nov 28, 2024 •
edited
Loading

ServicesBackend improvements.

  • remove unnecessary wrapping of DoCommand in thread
  • propagate timeout from SendCommand to zmq::poll in PollAndSend. Previously the timeout was only used as the time taken to wait for a reply, but the send poll timed out after an unrelated short amount of time (services backend configure variable, default 50ms). That would mean a SendCommand may return in 50ms with "no listener" even if the timeout specified was 5000ms.

This PR builds on #36.

superkanalysis and others added 8 commits November 14, 2024 11:29
@superkanalysis
Add Ready function to Services(Backend) to check for connections to b…
0927bd8 
…ackend sockets
don't poll PUB socket as it always returns true immediately, making t…
0cfbe77 
…he timeout ineffective
need mutex lock as socket is not thread safe
2a035bc
replace sleep on construction with poll on services backend socket
4da4ac7
simplify ServicesBackend by not running call to DoCommand in a separa…
a4db12f 
…te thread
@superkanalysis
Propagate timeout of ServicesBackend::SendCommand to underlying PollA…
5ef8982 
…ndSend so that poll time is timeout (rather than class member). Could be problematic as it means a user calling SendCommand with a long timeout could cause backend to get stuck, but only if the poll fails (in which case it can't do anything anyway)...
remove printfs
3270267
@brichards64
Merge branch 'main' into backendimpr
6420e05
@brichards64 brichards64 merged commit 437853a into ToolDAQ:main Jul 30, 2025
1 check failed
@marc1uk marc1uk deleted the backendimpr branch November 20, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc1uk @brichards64 @superkanalysis