Implement SimState.wrap_positions using pbc_wrap_batched #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@thomasloux Could you please review this? I created a new branch without the test since my previous commits got messy after other changes in my fork. So I opened a clean PR. |
Collaborator
|
Could you link the other PR for context? |
Contributor
Author
|
Previous PR: #345 |
thomasloux
previously requested changes
Nov 24, 2025
torch_sim/state.py
Outdated
| """ | ||
| # TODO: implement a wrapping method | ||
| return self.positions | ||
| if not self.pbc: |
Collaborator
There was a problem hiding this comment.
now self.pbc is a Boolean (3,) shaped Tensor. So this expression won't work here. I don't think this piece of code should need a test, a static typing check would have catched that. replace with if not self.pbc.any()
Collaborator
|
For reference of use of static check #339 |
CompRhys
dismissed
thomasloux’s stale review
I have addressed the blocking comment on this abandoned PR
thomasloux
approved these changes
Feb 5, 2026
Collaborator
thomasloux
left a comment
thomasloux
left a comment
There was a problem hiding this comment.
Not sure the tests are super necessary, but good for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Before a pull request can be merged, the following items must be checked:
Resolves #343