fix: correct ZwCreateFile disposition, NTSTATUS errors, recursion, an…#10
Merged
fix: correct ZwCreateFile disposition, NTSTATUS errors, recursion, an…#10
Conversation
…d debug buffer ZwCreateFile (File.c): return correct IoStatusBlock->Information based on actual disposition (FILE_CREATED, FILE_OPENED, FILE_SUPERSEDED, etc.) using GetLastError() after CreateFileW. Add missing error translations for STATUS_OBJECT_NAME_COLLISION, STATUS_SHARING_VIOLATION, STATUS_OBJECT_PATH_NOT_FOUND. ZwDeleteKey/ZwDeleteKeyEx (Registry.c): convert LSTATUS to proper NTSTATUS codes via RegistryErrorToNtstatus helper instead of returning raw Win32 error values. ExAcquireResourceExclusiveLite/SharedLite (Resource.c): replace unbounded recursion with for(;;) loop to prevent stack overflow under sustained contention. DebugPrintInternal (Debug.h): always null-terminate stack buffer even when _vsnprintf_s fills it completely, preventing printf from reading past the buffer. NtStatus.h: add STATUS_OBJECT_NAME_COLLISION, STATUS_SHARING_VIOLATION. Tests updated to match corrected kernel semantics. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d debug buffer
ZwCreateFile (File.c): return correct IoStatusBlock->Information based on actual disposition (FILE_CREATED, FILE_OPENED, FILE_SUPERSEDED, etc.) using GetLastError() after CreateFileW. Add missing error translations for STATUS_OBJECT_NAME_COLLISION, STATUS_SHARING_VIOLATION, STATUS_OBJECT_PATH_NOT_FOUND.
ZwDeleteKey/ZwDeleteKeyEx (Registry.c): convert LSTATUS to proper NTSTATUS codes via RegistryErrorToNtstatus helper instead of returning raw Win32 error values.
ExAcquireResourceExclusiveLite/SharedLite (Resource.c): replace unbounded recursion with for(;;) loop to prevent stack overflow under sustained contention.
DebugPrintInternal (Debug.h): always null-terminate stack buffer even when _vsnprintf_s fills it completely, preventing printf from reading past the buffer.
NtStatus.h: add STATUS_OBJECT_NAME_COLLISION, STATUS_SHARING_VIOLATION.
Tests updated to match corrected kernel semantics.