Open
Conversation
Owner
|
ぎゃー。 printha.cppの部分のs/cmake_source_dir/printha_datadir/に関しては了解しました。cmakeの方は/usr/share/@category@/printha/...系の人のために、ちょっと工夫してみました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
はじめまして、openSUSEでいろいろやってる者です。
さて、早速ではありますが、printhaをパッケージ化するにあたって、1点問題を見つけましたので
修正してみました。具体的には、CMAKE_SOURCE_DIRをソースコード内で参照してしまっているため、
"make install"してもビルドに使用していたディレクトリを削除できない、という問題への対応です。
ちなみに、openSUSE用のパッケージは下記で作成しています。
https://build.opensuse.org/package/show/home:belphegor_belbel/printha
よろしければ取り込んでいただけると幸いです。
それでは。