Skip to content

Fixed cross-platform file copy in Bazel rule #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WhiteElephant-abc merged 2 commits into from
Jan 24, 2026
Merged

Fixed cross-platform file copy in Bazel rule #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00f6766
🐛 fix: use cross-platform file copy in rename_files rule
opencode-agent[bot] Jan 24, 2026
a02f263
🐛 fix: add force flags to cross-platform file copy in rename_files rule
opencode-agent[bot] Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions rule/rename_files.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ def _rename_files_impl(ctx):
"""Implementation of the rename_files rule."""
output_files = []

# 检测当前平台是否为 Windows
is_windows = ctx.target_platform_has_constraint(ctx.attr._windows_constraint[platform_common.ConstraintValueInfo])

for src in ctx.files.srcs:
# 创建重命名后的输出文件
if "_processed.mcfunction" in src.basename:
Expand All @@ -27,15 +30,25 @@ def _rename_files_impl(ctx):
output_file = ctx.actions.declare_file(output_name, sibling = src)
output_files.append(output_file)

# 复制文件并重命名
ctx.actions.run(
inputs = [src],
outputs = [output_file],
executable = "cmd",
arguments = ["/c", "copy", src.path.replace("/", "\\"), output_file.path.replace("/", "\\")],
mnemonic = "RenameFile",
progress_message = "Renaming %s to %s" % (src.basename, output_name),
)
# 跨平台复制文件并重命名
if is_windows:
# Windows 使用 cmd copy /y 命令，/y 选项避免覆盖提示
ctx.actions.run_shell(
inputs = [src],
outputs = [output_file],
command = "copy /y \"{}\" \"{}\"".format(src.path.replace("/", "\\"), output_file.path.replace("/", "\\")),
mnemonic = "RenameFile",
progress_message = "Renaming %s to %s" % (src.basename, output_name),
)
else:
# Unix-like 系统使用 cp -f 命令，-f 选项强制覆盖
ctx.actions.run_shell(
inputs = [src],
outputs = [output_file],
command = "cp -f \"{}\" \"{}\"".format(src.path, output_file.path),
mnemonic = "RenameFile",
progress_message = "Renaming %s to %s" % (src.basename, output_name),
)

return [DefaultInfo(files = depset(output_files))]

Expand All @@ -46,5 +59,8 @@ rename_files = rule(
allow_empty = True,
allow_files = [".mcfunction", ".raw.mcfunction"],
),
"_windows_constraint": attr.label(
default = "@platforms//os:windows",
),
},
)
Loading