[Fix] Recipes lost on respawn due to onCloneCapability#171
Open
ASchneider-GitHub wants to merge 3 commits intoTowdium:1.20.1from
Open
[Fix] Recipes lost on respawn due to onCloneCapability#171ASchneider-GitHub wants to merge 3 commits intoTowdium:1.20.1from
ASchneider-GitHub wants to merge 3 commits intoTowdium:1.20.1from
Conversation
|
This explains everything, I just tested it in my 1.18 world and dying then leaving the world cleared my recipes. I really hope towdium is willing to implement this for all versions (especially 1.18). I don't plan on dying often, but when I do I want it to not suck as much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capabilities attached to the player are lost on respawn because they weren't being passed to the new RecordPlayer object correctly. This leaves the player's recipe list empty in memory. When the player leaves, the empty recipe list is written to the save data erasing all previously-stored recipes.
This needs to be backported to other applicable branches (like 1.18)
This also fixes issues #170 and probably #156