Conversation
ue71603
added
the
bug
skinkie
reviewed
May 30, 2025
skinkie
previously approved these changes
May 30, 2025
trurlurl
previously approved these changes
Jun 3, 2025
trurlurl
added
the
needs documentation update
Aurige
reviewed
Jun 4, 2025
This reverts commit 0c65fbd.
Contributor
Author
|
still not happy, but it solves the problem of Christophe and you. so let's do this. |
Contributor
|
What are you not happy about, this was your proposal? :-) |
Contributor
Author
|
I know. but you see that I reverted the reversion and we do the depreciation as you and Christophe discussed. Christophe says it should be a ServiceJourney and I am not that sure.. and the problem if a ServiceJourney is a specialed VehicleJourney is not solved. But it is an improvement and we are out of time. |
Contributor
|
The fact that is is a ServiceJourney is from Transmodel ... if we want to change it, it is another level of discussion |
Aurige
approved these changes
Jun 18, 2025
skinkie
approved these changes
Jun 18, 2025
Aurige
added
document has been updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its From/To JourneyRef so the type is Journey and not VehicleJourney.
This is also necessary, because VehicleJourney and ServiceJourney are both derived from Journey, but not one form the other.