Skip to content

Rename dummy#939

Closed
skinkie wants to merge 3 commits intonextfrom
rename_dummy_2
Closed

Rename dummy#939
skinkie wants to merge 3 commits intonextfrom
rename_dummy_2

Conversation

@skinkie
Copy link
Copy Markdown
Contributor

@skinkie skinkie commented Jul 9, 2025

This pull request is in essence "trivial" because it only replaces _ with _Dummy.

But I think it does show that there are still things that look and feel wrong. For example, NeTEx defines the abstract "Organisation" it, is abstract so it cannot be used. The abstract object is not used to derive objects from. I wonder why we won't rename Organisation_Dummy to Organisation. In the overview below all elements that are in fact abstract, but still have a matching Dummy.

@Aurige @nick-knowles please review, and let me know if the Dummy element can be just renamed to the "Transmodel-abstract".

Pair: Assignment_Dummy in ./xsd/netex_framework/netex_genericFramework/netex_assignment_version.xsd
      Assignment       in ./xsd/netex_framework/netex_genericFramework/netex_assignment_version.xsd

Pair: CommonVehicleService_Dummy in ./xsd/netex_part_5/part5_rc/netex_nm_mobilityService_version.xsd
      CommonVehicleService       in ./xsd/netex_part_5/part5_rc/netex_nm_mobilityService_version.xsd

Pair: ConventionalModeOfOperation_Dummy in ./xsd/netex_framework/netex_reusableComponents/netex_modeOfOperation_version.xsd
      ConventionalModeOfOperation       in ./xsd/netex_framework/netex_reusableComponents/netex_modeOfOperation_version.xsd

Pair: CustomerEligibility_Dummy in ./xsd/netex_part_3/part3_salesTransactions/netex_customerEligibility_version.xsd
      CustomerEligibility       in ./xsd/netex_part_3/part3_salesTransactions/netex_customerEligibility_version.xsd

Pair: DeckEntrance_Dummy in ./xsd/netex_framework/netex_reusableComponents/netex_deckPlan_version.xsd
      DeckEntrance       in ./xsd/netex_framework/netex_reusableComponents/netex_deckPlan_version.xsd

Pair: DeckSpace_Dummy in ./xsd/netex_framework/netex_reusableComponents/netex_deckPlan_version.xsd
      DeckSpace       in ./xsd/netex_framework/netex_reusableComponents/netex_deckPlan_version.xsd

Pair: FareContractEntry_Dummy in ./xsd/netex_part_3/part3_salesTransactions/netex_salesContract_version.xsd
      FareContractEntry       in ./xsd/netex_part_3/part3_salesTransactions/netex_salesContract_version.xsd

Pair: FarePrice_Dummy in ./xsd/netex_part_3/part3_fares/netex_farePrice_version.xsd
      FarePrice       in ./xsd/netex_part_3/part3_fares/netex_farePrice_version.xsd

Pair: FareProduct_Dummy in ./xsd/netex_part_3/part3_fares/netex_fareProduct_version.xsd
      FareProduct       in ./xsd/netex_part_3/part3_fares/netex_fareProduct_version.xsd

Pair: GroupOfEntitiesRef_Dummy in ./xsd/netex_framework/netex_genericFramework/netex_grouping_support.xsd
      GroupOfEntitiesRef       in ./xsd/netex_framework/netex_genericFramework/netex_grouping_support.xsd

Pair: GroupOfPointsRef_Dummy in ./xsd/netex_framework/netex_genericFramework/netex_pointAndLink_support.xsd
      GroupOfPointsRef       in ./xsd/netex_framework/netex_genericFramework/netex_pointAndLink_support.xsd

Pair: InfrastructureLink_Dummy in ./xsd/netex_part_1/part1_networkDescription/netex_networkInfrastructure_version.xsd
      InfrastructureLink       in ./xsd/netex_part_1/part1_networkDescription/netex_networkInfrastructure_version.xsd

Pair: Interchange_Dummy in ./xsd/netex_part_2/part2_journeyTimes/netex_interchange_version.xsd
      Interchange       in ./xsd/netex_part_2/part2_journeyTimes/netex_interchange_version.xsd

Pair: Journey_Dummy in ./xsd/netex_part_2/part2_journeyTimes/netex_journey_version.xsd
      Journey       in ./xsd/netex_part_2/part2_journeyTimes/netex_journey_version.xsd

Pair: MobilityService_Dummy in ./xsd/netex_part_5/part5_rc/netex_nm_mobilityService_version.xsd
      MobilityService       in ./xsd/netex_part_5/part5_rc/netex_nm_mobilityService_version.xsd

Pair: ModeOfOperation_Dummy in ./xsd/netex_framework/netex_reusableComponents/netex_modeOfOperation_version.xsd
      ModeOfOperation       in ./xsd/netex_framework/netex_reusableComponents/netex_modeOfOperation_version.xsd

Pair: Organisation_Dummy in ./xsd/netex_framework/netex_genericFramework/netex_organisation_version.xsd
      Organisation       in ./xsd/netex_framework/netex_genericFramework/netex_organisation_version.xsd

Pair: PriceableObject_Dummy in ./xsd/netex_part_3/part3_fares/netex_farePrice_version.xsd
      PriceableObject       in ./xsd/netex_part_3/part3_fares/netex_farePrice_version.xsd

Pair: Section_Dummy in ./xsd/netex_framework/netex_genericFramework/netex_section_version.xsd
      Section       in ./xsd/netex_framework/netex_genericFramework/netex_section_version.xsd

Pair: SecurityListing_Dummy in ./xsd/netex_framework/netex_reusableComponents/netex_securityList_version.xsd
      SecurityListing       in ./xsd/netex_framework/netex_reusableComponents/netex_securityList_version.xsd

Pair: TransportOrganisation_Dummy in ./xsd/netex_framework/netex_reusableComponents/netex_transportOrganisation_version.xsd
      TransportOrganisation       in ./xsd/netex_framework/netex_reusableComponents/netex_transportOrganisation_version.xsd

Pair: UsageParameter_Dummy in ./xsd/netex_part_3/part3_fares/netex_usageParameter_version.xsd
      UsageParameter       in ./xsd/netex_part_3/part3_fares/netex_usageParameter_version.xsd

Pair: VehiclePoolingService_Dummy in ./xsd/netex_part_5/part5_rc/netex_nm_mobilityService_version.xsd
      VehiclePoolingService       in ./xsd/netex_part_5/part5_rc/netex_nm_mobilityService_version.xsd

@skinkie skinkie closed this Jul 9, 2025
@skinkie skinkie deleted the rename_dummy_2 branch July 9, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants