Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is in essence "trivial" because it only replaces _ with _Dummy.
But I think it does show that there are still things that look and feel wrong. For example, NeTEx defines the abstract "Organisation" it, is abstract so it cannot be used. The abstract object is not used to derive objects from. I wonder why we won't rename Organisation_Dummy to Organisation. In the overview below all elements that are in fact abstract, but still have a matching Dummy.
@Aurige @nick-knowles please review, and let me know if the Dummy element can be just renamed to the "Transmodel-abstract".