Remove required 'id' attribute from accessibility schema#977
Merged
Conversation
Removed the required 'id' attribute from the element "AccessibilityLimitation"
TuThoThai
added
the
bug
skinkie
approved these changes
Oct 24, 2025
Collaborator
Author
ue71603
approved these changes
Oct 24, 2025
Collaborator
Author
|
Merged based on confirmation that id is not needed for AccessibilityLimitation as not referenced elsewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the merge of #970, I have looked more into details in elements that I believe do not need an "id" since they are not referened anywhere else.
One element addressed in this PR is "AccessibilityLimitation". As it is embedded within an physical item for which it describes its accessibility, I believe that having an "id" in the first place was a bug in the XSD. It does not appear in the documentation.