forked from MarvelousMovingMinds/UforU
-
Notifications
You must be signed in to change notification settings - Fork 3
Feat/fresh sesh #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BhattPrateek
wants to merge
15
commits into
master
Choose a base branch
from
feat/fresh-sesh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/fresh sesh #46
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
36c1f96
(feat) Add favorites link on main bar and favorite button to uni-list.
BhattPrateek 5d87c86
(Feat) Pass favorite universities link/method from top level parent.
BhattPrateek 52d3df1
(feat) Installed js-cookie library.
BhattPrateek a8a83aa
(feat)Add react router link (n/c).
BhattPrateek 925cca9
(feat) Implement favorite university feature/ route.
BhattPrateek 4ae04fb
(bug) Try connecting sockets without URL
epan 94dd4c0
Merge branch 'master' into bug/prod-socket-url-3
epan ef37f09
Merge pull request #47 from epan/bug/prod-socket-url-3
epan 195812a
(feat) Add favorites link on main bar and favorite button to uni-list.
BhattPrateek 1ec4ff2
(Feat) Pass favorite universities link/method from top level parent.
BhattPrateek a772c66
(feat) Installed js-cookie library.
BhattPrateek 383e50d
(feat)Add react router link (n/c).
BhattPrateek 11f9f9c
(feat) Implement favorite university feature/ route.
BhattPrateek 22482ca
(refactor) Fix duplicate favorites.
BhattPrateek 710d230
Merge branch 'feat/fresh-sesh' of https://github.com/TrendGame/UforU …
BhattPrateek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import React from 'react'; | ||
| import axios from 'axios'; | ||
| import { Router, Route, Link, IndexRoute, hashHistory, browserHistory, DefaultRoute, IndexLink } from 'react-router'; | ||
| import Cookies from 'js-cookie'; | ||
| import ResultListEntry from './ResultListEntry.jsx'; | ||
|
|
||
| class FavoritesPage extends React.Component { | ||
| constructor(props) { | ||
| super(props); | ||
|
|
||
| this.state = { | ||
| colleges: Cookies.getJSON("colleges") | ||
| }; | ||
| this.handleFavColleges = this.handleFavColleges.bind(this); | ||
| } | ||
|
|
||
| handleFavColleges(college) { | ||
| let prev = this.state.colleges; | ||
| let col = college; | ||
| console.log("Edge-Case Handled."); | ||
| } | ||
|
|
||
| render () { | ||
| return ( | ||
| <div> | ||
| {this.state.colleges.map((college, i) => { | ||
| return <ResultListEntry key={i} college={college} handleFav={this.handleFavColleges}/>; | ||
| })} | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export default FavoritesPage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,20 +2,29 @@ import React from 'react'; | |
| import ReactDOM from 'react-dom'; | ||
| import { Router, Route, Link, IndexRoute, hashHistory, browserHistory, DefaultRoute, IndexLink } from 'react-router'; | ||
| import io from 'socket.io-client'; | ||
| import Cookies from 'js-cookie'; | ||
|
|
||
| import Home from './components/Home.jsx'; | ||
| import Container from './components/Container.jsx'; | ||
| import FavoritesPage from './components/FavoritesPage.jsx' | ||
| import Results from './components/Results.jsx'; | ||
| import Survey from './components/Survey.jsx'; | ||
| import CommentsPage from './components/CommentsPage.jsx'; | ||
|
|
||
| class App extends React.Component { | ||
| constructor(props){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove this if it isn't doing anything. |
||
| super(props); | ||
| this.state = { | ||
| } | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <Router history={hashHistory}> | ||
| <Route path='/' component={Container}> | ||
| <IndexRoute component={Home} /> | ||
| <Route path='results' component={Results} /> | ||
| <Route path='favorites' component={FavoritesPage}/> | ||
| <Route path='college/:id' component={CommentsPage}/> | ||
| </Route> | ||
| </Router> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try and do 2 big things with this: