rt/ cleanup #80
Draft
rt/ cleanup #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoelvsten
added
📁 ./rt
ssoelvsten
force-pushed
the
fork/dev/rt-cleanup
branch
3 times, most recently
from
7e4e426 to
9373972
Compare
aslanix
force-pushed
the
dev-integrity
branch
from
22d5b5e to
ae3b361
Compare
This brings the name closer to the actual meaning of this construction.
This way, is is less likely one by accident exports the wrong function under a different name
Trailing whitespaces, missing semi colons, missing trailing comma on objects, odd comment structur, outcommented dead code, odd order of functions, ...
Trailing whitespace, missing semi colons, hard to understand comments, ...
Trailing whitespace, missing semi colons, odd comments, dead code, ...
There is no reason to have an inconsistent access to `scheduer.__currentThread`; one may as well just access it directly (as is done in the Runtime Monitor). Furthermore, why the `__` when the variable is treated as public anyways?
This function is only called in one placed with these arguments given. This is essentially dead code.
There seems to be no reason why we have to have an O(n) unblocking logic. Furthermore, this is much cleaner.
This much better conveys the meaning of this argument, especially from the call site
This allows us later to store an initialised module. For now, it cleans up the scheduler by decreasing the number of responsibilities.
ssoelvsten
force-pushed
the
fork/dev/rt-cleanup
branch
from
9373972 to
c68f75a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preliminary clean up as I'm looking at adding nomadic modules throughout the runtime ( #66 ).