lib/ cleanup #91
Open
lib/ cleanup #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the name closer to the actual meaning of this construction.
This way, is is less likely one by accident exports the wrong function under a different name
It is old, unused, unmaintained, and superseeded by a recent BSc project
If we truly need it later, then we can easily reimplement this library. At that point we might have a context (worker stealing?) that can inform the API design
This was only a temporary LLM-generated library never meant to be kept
In a separate branch, I am already implementing this anew with a proper API (but still not properly balanced).
On a seperate branch, I am already trying to implement this anew
These should be reimplemented as a new IO library with an entirely new API.
This also adds the start of a 'Time' module (which is what I initially thought would be the place to put the new timeout function.
This removes some derivable operations out of the TCB, e.g. `fprintln` and `fprintlnWithLabels`. At the same time, `inputLine` has been semi-generalised to be `freadln` (read a line from a file) and `stdin` is now a derivable capability similar to the one needed for printing to `stdout`. This also fixes the missing access to `stderr`. For now, there are lots of `runtime/core` tests that rely on the preamble functions, `print` and so on. In the long run, these tests should be rewritten such that they are completely independent. The tests for the preamble itself have been moved into a separate folder.
This test was in 'core' even though it was testing 'ifc' stuff. Furthermore, it was on testing one particular combination instead of each possible.
ssoelvsten
added
📁 ./lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #84 but without renaming
printWithLabels(though the inconsistency should be resolved at some point to decrease the struggle studens have to build a mental model).Please only merge when happy. 😉