Open
Conversation
…ler when grepping
… and open a file using it
…can be sure earlier files are fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements reading and writing of external field checkpoint files, the last step in effectively removing MPI-IO from TROVE. Some traces of MPI-IO are probably still present.
The PR relies on, and should be merged after, #48.
All tests pass except when using more than one process with the non-mpi version, where the intensity step either segfaults while running or produces incorrect results (compared to the regression test standard results). This bug is unrelated to the changes made in this PR and is present in
merge-develop-mpi.The output files from the relevant step
file2.inparej0_extfield.chkandj0_matelem.chk. Currently they are not bit-for-bit identical between MPI and non-MPI versions. Despite this, the results match the regression test accurately enough to pass. @ageorgou do you think this needs looking into?