Attach tables and doc strings to correct step#17
Merged
dcrockwell merged 9 commits intoTrustBound:developfrom Feb 3, 2026
Merged
Attach tables and doc strings to correct step#17dcrockwell merged 9 commits intoTrustBound:developfrom
dcrockwell merged 9 commits intoTrustBound:developfrom
Conversation
Release 1.0.1 - Documentation improvements with tested code examples
Release 1.0.2 — Test skipping and CI exit codes
Release 1.0.3 — Cleaner test pipelines
Release v1.1.0 - Gherkin BDD, Test Filtering, JSON Reporter, and Per-Test Timing
Release v1.2.0: Snapshot Testing
Release: Dream Test v2 (new runner + reporting model)
Release 2.1.0: runner hooks
Update release workflows
Contributor
|
Thanks for this! Looking at it now |
Contributor
|
Looks great! Fantastic work. Thank you! |
Contributor
|
I'm merging into develop, then I will release as 2.1.1 with attribution to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix parser bug where DataTables and DocStrings were attached to the wrong step when a scenario had multiple steps with tables. The parser was unnecessarily reversing the
current_stepslist twice when attaching arguments, but since steps are prepended during parsing, the most recent step is already at the head of the list.Related Issue
N/A
Type of Change
Changes Made
list.reverseinclose_doc_string- work directly with head ofcurrent_stepslist.reverseinadd_data_table_row- same optimizationmulti_table_test.gleamthat verifies multiple steps with tables are parsed correctlyTesting
make test)gleam formatDocumentation
Breaking Changes
N/A
Checklist
Screenshots (if applicable)
N/A
Additional Context
The bug manifested when parsing scenarios like:
Before the fix, both tables would be attached to the same step (or the wrong step), because
list.reversewas being called oncurrent_stepsbefore finding "the last step", but steps are already stored with the most recent at the head (prepended during parsing).